Fix for issue9662, patch by Łukasz Langa in issue5504.

ronaldoussoren · ronaldoussoren · commit 2decf22b9549 · 2010-09-05T18:25:59.000Z
diff --git a/Modules/_ctypes/callbacks.c b/Modules/_ctypes/callbacks.c
@@ -416,9 +416,13 @@ CThunkObject *_ctypes_alloc_callback(PyObject *callable,
                      "ffi_prep_cif failed with %d", result);
         goto error;
     }
+#if defined(X86_DARWIN) || defined(POWERPC_DARWIN)
+    result = ffi_prep_closure(p->pcl_write, &p->cif, closure_fcn, p);
+#else
     result = ffi_prep_closure_loc(p->pcl_write, &p->cif, closure_fcn,
 				  p,
 				  p->pcl_exec);
+#endif
     if (result != FFI_OK) {
         PyErr_Format(PyExc_RuntimeError,
                      "ffi_prep_closure failed with %d", result);
diff --git a/Modules/_ctypes/libffi_osx/include/ffi.h b/Modules/_ctypes/libffi_osx/include/ffi.h
@@ -264,6 +264,9 @@ ffi_prep_closure(
 	void			(*fun)(ffi_cif*,void*,void**,void*),
 	void*			user_data);
 
+void ffi_closure_free(void *);
+void *ffi_closure_alloc (size_t size, void **code);
+
 typedef struct ffi_raw_closure {
 	char		tramp[FFI_TRAMPOLINE_SIZE];
 	ffi_cif*	cif;
@@ -349,4 +352,4 @@ ffi_call(
 }
 #endif
 
-#endif	// #ifndef LIBFFI_H
+#endif	// #ifndef LIBFFI_H
diff --git a/Modules/_ctypes/malloc_closure.c b/Modules/_ctypes/malloc_closure.c
@@ -106,7 +106,6 @@ void *ffi_closure_alloc(size_t ignored, void** codeloc)
         return NULL;
     item = free_list;
     free_list = item->next;
-	*codeloc = (void *)item;
+    *codeloc = (void *)item;
     return (void *)item;
 }
-
diff --git a/setup.py b/setup.py
@@ -1657,6 +1657,7 @@ def detect_ctypes(self, inc_dirs, lib_dirs):
         depends = ['_ctypes/ctypes.h']
 
         if sys.platform == 'darwin':
+            sources.append('_ctypes/malloc_closure.c')
             sources.append('_ctypes/darwin/dlfcn_simple.c')
             extra_compile_args.append('-DMACOSX')
             include_dirs.append('_ctypes/darwin')

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,6 @@ void ffi_closure_alloc(size_t ignored, void* codeloc)`
`106`	`106`	`return NULL;`
`107`	`107`	`item = free_list;`
`108`	`108`	`free_list = item->next;`
`109`		`- codeloc = (void )item;`
	`109`	`+ codeloc = (void )item;`
`110`	`110`	`return (void *)item;`
`111`	`111`	`}`
`112`		`-`