bpo-32733: Make test_coroutines robust against -Werror (GH-5487)

njsmith · web-flow · commit 2efb9735899c · 2018-02-01T20:55:55.000-08:00
diff --git a/Lib/test/test_coroutines.py b/Lib/test/test_coroutines.py
@@ -2152,15 +2152,10 @@ def a2():
 
         def check(depth, msg):
             sys.set_coroutine_origin_tracking_depth(depth)
-            with warnings.catch_warnings(record=True) as wlist:
+            with self.assertWarns(RuntimeWarning) as cm:
                 a2()
                 support.gc_collect()
-            # This might be fragile if other warnings somehow get triggered
-            # inside our 'with' block... let's worry about that if/when it
-            # happens.
-            self.assertTrue(len(wlist) == 1)
-            self.assertIs(wlist[0].category, RuntimeWarning)
-            self.assertEqual(msg, str(wlist[0].message))
+            self.assertEqual(msg, str(cm.warning))
 
         orig_depth = sys.get_coroutine_origin_tracking_depth()
         try:
