Issue #18339: use with self.assertRaises() to make test case more readable

tiran · tiran · commit 3126a3d15635 · 2013-07-01T23:00:22.000+02:00
diff --git a/Lib/test/test_pickle.py b/Lib/test/test_pickle.py
@@ -117,9 +117,11 @@ class CPicklerUnpicklerObjectTests(AbstractPicklerUnpicklerObjectTests):
 
         def test_issue18339(self):
             unpickler = self.unpickler_class(io.BytesIO())
-            self.assertRaises(TypeError, setattr, unpickler, "memo", object)
+            with self.assertRaises(TypeError):
+                unpickler.memo = object
             # used to cause a segfault
-            self.assertRaises(ValueError, setattr, unpickler, "memo", {-1: None})
+            with self.assertRaises(ValueError):
+                unpickler.memo = {-1: None}
             unpickler.memo = {1: None}
 
     class CDispatchTableTests(AbstractDispatchTableTests):
