port from 3.2 - Fix the urllib closing issue which hangs on particular ftp urls/ftp servers. closes issue11199

orsenthil · orsenthil · commit 3270d11d8aee · 2012-03-15T13:28:27.000-07:00
diff --git a/Lib/urllib/response.py b/Lib/urllib/response.py
@@ -64,11 +64,11 @@ def __init__(self, fp, closehook, *hookargs):
         self.hookargs = hookargs
 
     def close(self):
-        addbase.close(self)
         if self.closehook:
             self.closehook(*self.hookargs)
             self.closehook = None
             self.hookargs = None
+        addbase.close(self)
 
 class addinfo(addbase):
     """class to add an info() method to an open file."""
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -24,6 +24,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #11199: Fix the with urllib which hangs on particular ftp urls.
+
 - Issue #14222: Use the new time.steady() function instead of time.time() for
   timeout in queue and threading modules to not be affected of system time
   update.
