Michael Hudson pointed out that the Dialect_Type object isn't INCREF'd. Why

Skip Montanaro · Skip Montanaro · commit 32c5d424fd31 · 2005-06-15T13:35:08.000Z
this worked is a bit mystical.  Perhaps it never gets freed because the
object just happens never to be DECREF'd (but that seems unlikely).
diff --git a/Modules/_csv.c b/Modules/_csv.c
@@ -1587,6 +1587,7 @@ init_csv(void)
 	}
 
         /* Add the Dialect type */
+	Py_INCREF(&Dialect_Type);
         if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type))
                 return;
 

Original file line number	Diff line number	Diff line change
`@@ -1587,6 +1587,7 @@ init_csv(void)`
`1587`	`1587`	`}`
`1588`	`1588`
`1589`	`1589`	`/* Add the Dialect type */`
	`1590`	`+ Py_INCREF(&Dialect_Type);`
`1590`	`1591`	`if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type))`
`1591`	`1592`	`return;`
`1592`	`1593`