Issue #29094: Offsets in a ZIP file created with extern file object and modes

serhiy-storchaka · serhiy-storchaka · commit 34cba334034d · 2017-01-01T19:00:30.000+02:00
"w" and "x" now are relative to the start of the file.
diff --git a/Lib/zipfile.py b/Lib/zipfile.py
@@ -1028,11 +1028,12 @@ def __init__(self, file, mode="r", compression=ZIP_STORED, allowZip64=True):
                 # set the modified flag so central directory gets written
                 # even if no files are added to the archive
                 self._didModify = True
+                self._start_disk = 0
                 try:
-                    self.start_dir = self._start_disk = self.fp.tell()
+                    self.start_dir = self.fp.tell()
                 except (AttributeError, OSError):
                     self.fp = _Tellable(self.fp)
-                    self.start_dir = self._start_disk = 0
+                    self.start_dir = 0
                     self._seekable = False
                 else:
                     # Some file-like objects can provide tell() but not seek()
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -140,6 +140,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #29094: Offsets in a ZIP file created with extern file object and modes
+  "w" and "x" now are relative to the start of the file.
+
 - Issue #13051: Fixed recursion errors in large or resized
   curses.textpad.Textbox.  Based on patch by Tycho Andersen.
 
