gh-120268: Prohibit passing None to _pydatetime.date.fromtimestamp (#120269)

Eclips4 · web-flow · commit 34f5ae69fe9a · 2024-06-08T16:45:57.000-04:00
This makes the pure Python implementation consistent with the C implementation.
diff --git a/Lib/_pydatetime.py b/Lib/_pydatetime.py
@@ -966,6 +966,8 @@ def __new__(cls, year, month=None, day=None):
     @classmethod
     def fromtimestamp(cls, t):
         "Construct a date from a POSIX timestamp (like time.time())."
+        if t is None:
+            raise TypeError("'NoneType' object cannot be interpreted as an integer")
         y, m, d, hh, mm, ss, weekday, jday, dst = _time.localtime(t)
         return cls(y, m, d)
 
diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py
@@ -1336,6 +1336,11 @@ def test_insane_fromtimestamp(self):
             self.assertRaises(OverflowError, self.theclass.fromtimestamp,
                               insane)
 
+    def test_fromtimestamp_with_none_arg(self):
+        # See gh-120268 for more details
+        with self.assertRaises(TypeError):
+            self.theclass.fromtimestamp(None)
+
     def test_today(self):
         import time
 
diff --git a/Misc/NEWS.d/next/Library/2024-06-08-14-36-40.gh-issue-120268.MNpd1q.rst b/Misc/NEWS.d/next/Library/2024-06-08-14-36-40.gh-issue-120268.MNpd1q.rst
@@ -0,0 +1,2 @@
+Prohibit passing ``None`` to pure-Python :meth:`datetime.date.fromtimestamp`
+to achieve consistency with C-extension implementation.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Prohibit passing ``None`` to pure-Python :meth:`datetime.date.fromtimestamp`
	`2`	`+to achieve consistency with C-extension implementation.`