Apply suggestions from code review

serhiy-storchaka · erlend-aasland · web-flow · commit 37725be0abae · 2023-12-14T08:27:01.000+02:00
Co-authored-by: Erlend E. Aasland &lt;erlend.aasland@protonmail.com&gt;
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -3323,10 +3323,12 @@ win32_lchmod(LPCWSTR path, int mode)
     if (attr == INVALID_FILE_ATTRIBUTES) {
         return 0;
     }
-    if (mode & _S_IWRITE)
+    if (mode & _S_IWRITE) {
         attr &= ~FILE_ATTRIBUTE_READONLY;
-    else
+    }
+    else {
         attr |= FILE_ATTRIBUTE_READONLY;
+    }
     return SetFileAttributesW(path, attr);
 }
 #endif
@@ -3404,14 +3406,16 @@ os_chmod_impl(PyObject *module, path_t *path, int mode, int dir_fd,
             if (GetFileInformationByHandleEx(hfile, FileBasicInfo,
                                              &info, sizeof(info)))
             {
-                if (mode & _S_IWRITE)
+                if (mode & _S_IWRITE) {
                     info.FileAttributes &= ~FILE_ATTRIBUTE_READONLY;
-                else
+                }
+                else {
                     info.FileAttributes |= FILE_ATTRIBUTE_READONLY;
+                }
                 result = SetFileInformationByHandle(hfile, FileBasicInfo,
                                                     &info, sizeof(info));
             }
-            CloseHandle(hfile);
+            (void)CloseHandle(hfile);
         }
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -3323,10 +3323,12 @@ win32_lchmod(LPCWSTR path, int mode)`
`3323`	`3323`	`if (attr == INVALID_FILE_ATTRIBUTES) {`
`3324`	`3324`	`return 0;`
`3325`	`3325`	`}`
`3326`		`- if (mode & _S_IWRITE)`
	`3326`	`+ if (mode & _S_IWRITE) {`
`3327`	`3327`	`attr &= ~FILE_ATTRIBUTE_READONLY;`
`3328`		`- else`
	`3328`	`+ }`
	`3329`	`+ else {`
`3329`	`3330`	`attr \|= FILE_ATTRIBUTE_READONLY;`
	`3331`	`+ }`
`3330`	`3332`	`return SetFileAttributesW(path, attr);`
`3331`	`3333`	`}`
`3332`	`3334`	`#endif`
`@@ -3404,14 +3406,16 @@ os_chmod_impl(PyObject module, path_t path, int mode, int dir_fd,`
`3404`	`3406`	`if (GetFileInformationByHandleEx(hfile, FileBasicInfo,`
`3405`	`3407`	`&info, sizeof(info)))`
`3406`	`3408`	`{`
`3407`		`- if (mode & _S_IWRITE)`
	`3409`	`+ if (mode & _S_IWRITE) {`
`3408`	`3410`	`info.FileAttributes &= ~FILE_ATTRIBUTE_READONLY;`
`3409`		`- else`
	`3411`	`+ }`
	`3412`	`+ else {`
`3410`	`3413`	`info.FileAttributes \|= FILE_ATTRIBUTE_READONLY;`
	`3414`	`+ }`
`3411`	`3415`	`result = SetFileInformationByHandle(hfile, FileBasicInfo,`
`3412`	`3416`	`&info, sizeof(info));`
`3413`	`3417`	`}`
`3414`		`- CloseHandle(hfile);`
	`3418`	`+ (void)CloseHandle(hfile);`
`3415`	`3419`	`}`
`3416`	`3420`	`}`
`3417`	`3421`	`else {`