bpo-44273: Improve syntax error message for assigning to "..." (GH-26477)

serhiy-storchaka · web-flow · commit 39dd141a4ba6 · 2021-06-01T12:07:05.000+01:00
Use "ellipsis" instead of "Ellipsis" in syntax error messages to eliminate confusion with built-in variable Ellipsis.
diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py
@@ -93,7 +93,7 @@
 
 >>> ... = 1
 Traceback (most recent call last):
-SyntaxError: cannot assign to Ellipsis here. Maybe you meant '==' instead of '='?
+SyntaxError: cannot assign to ellipsis here. Maybe you meant '==' instead of '='?
 
 >>> `1` = 1
 Traceback (most recent call last):
diff --git a/Parser/pegen.c b/Parser/pegen.c
@@ -217,7 +217,7 @@ _PyPegen_get_expr_name(expr_ty e)
                 return "True";
             }
             if (value == Py_Ellipsis) {
-                return "Ellipsis";
+                return "ellipsis";
             }
             return "literal";
         }

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ _PyPegen_get_expr_name(expr_ty e)`
`217`	`217`	`return "True";`
`218`	`218`	`}`
`219`	`219`	`if (value == Py_Ellipsis) {`
`220`		`- return "Ellipsis";`
	`220`	`+ return "ellipsis";`
`221`	`221`	`}`
`222`	`222`	`return "literal";`
`223`	`223`	`}`