Issue #25761: Fixed reference leak added in previous changeset (5c670af0100f).

serhiy-storchaka · serhiy-storchaka · commit 3ac5380d249e · 2015-12-07T11:32:00.000+02:00
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -5152,6 +5152,7 @@ load_dict(UnpicklerObject *self)
     if ((j - i) % 2 != 0) {
         PickleState *st = _Pickle_GetGlobalState();
         PyErr_SetString(st->UnpicklingError, "odd number of items for DICT");
+        Py_DECREF(dict);
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -5152,6 +5152,7 @@ load_dict(UnpicklerObject *self)`
`5152`	`5152`	`if ((j - i) % 2 != 0) {`
`5153`	`5153`	`PickleState *st = _Pickle_GetGlobalState();`
`5154`	`5154`	`PyErr_SetString(st->UnpicklingError, "odd number of items for DICT");`
	`5155`	`+ Py_DECREF(dict);`
`5155`	`5156`	`return -1;`
`5156`	`5157`	`}`
`5157`	`5158`