Strengthen the guard. The code doesn't work well with subclasses.

rhettinger · rhettinger · commit 3ad05763a6d6 · 2009-05-29T22:11:22.000Z
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -8547,7 +8547,7 @@ unicode_maketrans(PyUnicodeObject *null, PyObject *args)
         }
     } else {
         /* x must be a dict */
-        if (!PyDict_Check(x)) {
+        if (!PyDict_CheckExact(x)) {
             PyErr_SetString(PyExc_TypeError, "if you give only one argument "
                             "to maketrans it must be a dict");
             goto err;

Original file line number	Diff line number	Diff line change
`@@ -8547,7 +8547,7 @@ unicode_maketrans(PyUnicodeObject null, PyObject args)`
`8547`	`8547`	`}`
`8548`	`8548`	`} else {`
`8549`	`8549`	`/* x must be a dict */`
`8550`		`- if (!PyDict_Check(x)) {`
	`8550`	`+ if (!PyDict_CheckExact(x)) {`
`8551`	`8551`	`PyErr_SetString(PyExc_TypeError, "if you give only one argument "`
`8552`	`8552`	`"to maketrans it must be a dict");`
`8553`	`8553`	`goto err;`