bpo-40275: Avoid importing asyncio in test.support (GH-19600)

serhiy-storchaka · web-flow · commit 3c8a5b459d68 · 2020-04-25T10:04:10.000+03:00
* Import asyncio lazily in unittest (only when IsolatedAsyncioTestCase is used).
* Import asyncio.events lazily in test.support.
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py
@@ -3,7 +3,6 @@
 if __name__ != 'test.support':
     raise ImportError('support must be imported from the test package')
 
-import asyncio.events
 import collections.abc
 import contextlib
 import errno
@@ -3260,6 +3259,7 @@ def __gt__(self, other):
 
 def maybe_get_event_loop_policy():
     """Return the global event loop policy if one is set, else return None."""
+    import asyncio.events
     return asyncio.events._event_loop_policy
 
 # Helpers for testing hashing.
diff --git a/Lib/unittest/__init__.py b/Lib/unittest/__init__.py
@@ -57,7 +57,6 @@ def testMultiply(self):
 __unittest = True
 
 from .result import TestResult
-from .async_case import IsolatedAsyncioTestCase
 from .case import (addModuleCleanup, TestCase, FunctionTestCase, SkipTest, skip,
                    skipIf, skipUnless, expectedFailure)
 from .suite import BaseTestSuite, TestSuite
@@ -66,6 +65,7 @@ def testMultiply(self):
 from .main import TestProgram, main
 from .runner import TextTestRunner, TextTestResult
 from .signals import installHandler, registerResult, removeResult, removeHandler
+# IsolatedAsyncioTestCase will be imported lazily.
 
 # deprecated
 _TextTestResult = TextTestResult
@@ -78,3 +78,18 @@ def load_tests(loader, tests, pattern):
     # top level directory cached on loader instance
     this_dir = os.path.dirname(__file__)
     return loader.discover(start_dir=this_dir, pattern=pattern)
+
+
+# Lazy import of IsolatedAsyncioTestCase from .async_case
+# It imports asyncio, which is relatively heavy, but most tests
+# do not need it.
+
+def __dir__():
+    return globals().keys() | {'IsolatedAsyncioTestCase'}
+
+def __getattr__(name):
+    if name == 'IsolatedAsyncioTestCase':
+        global IsolatedAsyncioTestCase
+        from .async_case import IsolatedAsyncioTestCase
+        return IsolatedAsyncioTestCase
+    raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
diff --git a/Misc/NEWS.d/next/Library/2020-04-20-18-50-25.bpo-40275.Ofk6J8.rst b/Misc/NEWS.d/next/Library/2020-04-20-18-50-25.bpo-40275.Ofk6J8.rst
@@ -0,0 +1,2 @@
+The :mod:`asyncio` package is now imported lazily in :mod:`unittest` only
+when the :class:`~unittest.IsolatedAsyncioTestCase` class is used.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+The :mod:`asyncio` package is now imported lazily in :mod:`unittest` only
	`2`	+when the :class:`~unittest.IsolatedAsyncioTestCase` class is used.