Fix test_gc failure by fixing the bug test_gc found: __del__ methods were no

Yhg1s · Yhg1s · commit 3dfc3c14a20d · 2006-08-21T22:15:41.000Z
longer preventing classes from being cleaned up by the cycle-gc, after Guido
removed references to PyInstance_*.
diff --git a/Modules/gcmodule.c b/Modules/gcmodule.c
@@ -411,7 +411,7 @@ has_finalizer(PyObject *op)
 	if (PyGen_CheckExact(op))
 		return PyGen_NeedsFinalizing((PyGenObject *)op);
 	else
-		return 0;
+		return op->ob_type->tp_del != NULL;
 }
 
 /* Move the objects in unreachable with __del__ methods into `finalizers`.

Original file line number	Diff line number	Diff line change
`@@ -411,7 +411,7 @@ has_finalizer(PyObject *op)`
`411`	`411`	`if (PyGen_CheckExact(op))`
`412`	`412`	`return PyGen_NeedsFinalizing((PyGenObject *)op);`
`413`	`413`	`else`
`414`		`- return 0;`
	`414`	`+ return op->ob_type->tp_del != NULL;`
`415`	`415`	`}`
`416`	`416`
`417`	`417`	/* Move the objects in unreachable with __del__ methods into `finalizers`.