Issue #10359: Remove ";" after function definition, invalid in ISO C

Victor Stinner · Victor Stinner · commit 3e2b7171bf29 · 2010-11-09T09:32:19.000Z
diff --git a/Lib/distutils/tests/test_build_ext.py b/Lib/distutils/tests/test_build_ext.py
@@ -318,7 +318,7 @@ def test_compiler_option(self):
     def test_get_outputs(self):
         tmp_dir = self.mkdtemp()
         c_file = os.path.join(tmp_dir, 'foo.c')
-        self.write_file(c_file, 'void PyInit_foo(void) {};\n')
+        self.write_file(c_file, 'void PyInit_foo(void) {}\n')
         ext = Extension('foo', [c_file], optional=False)
         dist = Distribution({'name': 'xx',
                              'ext_modules': [ext]})
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
@@ -1792,7 +1792,7 @@ test_unicode_compare_with_ascii(PyObject *self) {
         return NULL;
     }
     Py_RETURN_NONE;
-};
+}
 
 /* This is here to provide a docstring for test_descr. */
 static PyObject *
diff --git a/Objects/weakrefobject.c b/Objects/weakrefobject.c
@@ -583,7 +583,7 @@ proxy_iternext(PyWeakReference *proxy)
 }
 
 
-WRAP_METHOD(proxy_bytes, "__bytes__");
+WRAP_METHOD(proxy_bytes, "__bytes__")
 
 
 static PyMethodDef proxy_methods[] = {
diff --git a/Python/import.c b/Python/import.c
@@ -3101,7 +3101,7 @@ imp_make_magic(long magic)
     buf[3] = (char) ((magic >> 24) & 0xff);
 
     return PyBytes_FromStringAndSize(buf, 4);
-};
+}
 
 static PyObject *
 imp_get_magic(PyObject *self, PyObject *noargs)

Original file line number	Diff line number	Diff line change
`@@ -1792,7 +1792,7 @@ test_unicode_compare_with_ascii(PyObject *self) {`
`1792`	`1792`	`return NULL;`
`1793`	`1793`	`}`
`1794`	`1794`	`Py_RETURN_NONE;`
`1795`		`-};`
	`1795`	`+}`
`1796`	`1796`
`1797`	`1797`	`/* This is here to provide a docstring for test_descr. */`
`1798`	`1798`	`static PyObject *`
Original file line number	Diff line number	Diff line change
`@@ -583,7 +583,7 @@ proxy_iternext(PyWeakReference *proxy)`
`583`	`583`	`}`
`584`	`584`
`585`	`585`
`586`		`-WRAP_METHOD(proxy_bytes, "__bytes__");`
	`586`	`+WRAP_METHOD(proxy_bytes, "__bytes__")`
`587`	`587`
`588`	`588`
`589`	`589`	`static PyMethodDef proxy_methods[] = {`