Issue #25318: Fix backslashreplace()

vstinner · vstinner · commit 3fa36ff5e499 · 2015-10-09T03:37:11.000+02:00
Fix code to estimate the needed space.
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -590,7 +590,7 @@ backslashreplace(_PyBytesWriter *writer, Py_ssize_t prealloc_per_char,
             incr = 2+4;
         else {
             assert(ch <= MAX_UNICODE);
-            incr = 2+6;
+            incr = 2+8;
         }
         if (size > PY_SSIZE_T_MAX - incr) {
             PyErr_SetString(PyExc_OverflowError,

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ backslashreplace(_PyBytesWriter *writer, Py_ssize_t prealloc_per_char,`
`590`	`590`	`incr = 2+4;`
`591`	`591`	`else {`
`592`	`592`	`assert(ch <= MAX_UNICODE);`
`593`		`- incr = 2+6;`
	`593`	`+ incr = 2+8;`
`594`	`594`	`}`
`595`	`595`	`if (size > PY_SSIZE_T_MAX - incr) {`
`596`	`596`	`PyErr_SetString(PyExc_OverflowError,`