Issue #4188: Avoid creating dummy thread objects when logging operations

pitrou · pitrou · commit 401edd69cf23 · 2010-12-17T17:42:16.000Z
from the threading module (with the internal verbose flag activated).
diff --git a/Lib/threading.py b/Lib/threading.py
@@ -55,8 +55,14 @@ def __init__(self, verbose=None):
         def _note(self, format, *args):
             if self._verbose:
                 format = format % args
-                format = "%s: %s\n" % (
-                    current_thread().name, format)
+                # Issue #4188: calling current_thread() can incur an infinite
+                # recursion if it has to create a DummyThread on the fly.
+                ident = _get_ident()
+                try:
+                    name = _active[ident].name
+                except KeyError:
+                    name = "<OS thread %d>" % ident
+                format = "%s: %s\n" % (name, format)
                 _sys.stderr.write(format)
 
 else:
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -20,6 +20,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #4188: Avoid creating dummy thread objects when logging operations
+  from the threading module (with the internal verbose flag activated).
+
 - Issue #10711: Remove HTTP 0.9 support from http.client.  The ``strict``
   parameter to HTTPConnection and friends is deprecated.
 
