#3614: Correct a typo in xmlrpc.client.

amauryfa · amauryfa · commit 41e36676cd82 · 2008-08-20T21:35:50.000Z
diff --git a/Lib/xmlrpc/client.py b/Lib/xmlrpc/client.py
@@ -1203,7 +1203,7 @@ def send_request(self, host, handler, request_body, debug):
         headers = {}
         if extra_headers:
             for key, val in extra_headers:
-                header[key] = val
+                headers[key] = val
         headers["Content-Type"] = "text/xml"
         headers["User-Agent"] = self.user_agent
         connection.request("POST", handler, request_body, headers)
@@ -1271,7 +1271,7 @@ def send_request(self, host, handler, request_body, debug):
         headers = {}
         if extra_headers:
             for key, val in extra_headers:
-                header[key] = val
+                headers[key] = val
         headers["Content-Type"] = "text/xml"
         headers["User-Agent"] = self.user_agent
         connection.request("POST", handler, request_body, headers)
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -46,6 +46,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #3614: Corrected a typo in xmlrpc.client, leading to a NameError
+  "global name 'header' is not defined".
+
 - Issue #2834: update the regular expression library to match the unicode
   standards of py3k. In other words, mixing bytes and unicode strings
   (be it as pattern, search string or replacement string) raises a TypeError.
