The 2.0b2 change to write .pyc files in exclusive mode (if possible)

tim-one · tim-one · commit 42c83afd14e1 · 2000-09-29T04:03:10.000Z
unintentionally caused them to get written in text mode under Windows.
As a result, when .pyc files were later read-- in binary mode --the
magic number was always wrong (note that .pyc magic numbers deliberately
include \r and \n characters, so this was "good" breakage, 100% across
all .pyc files, not random corruption in a subset).  Fixed that.
diff --git a/Python/import.c b/Python/import.c
@@ -646,7 +646,12 @@ open_exclusive(char *filename)
 	*/
 	int fd;
 	(void) unlink(filename);
-	fd = open(filename, O_EXCL|O_CREAT|O_WRONLY|O_TRUNC, 0666);
+	fd = open(filename, O_EXCL|O_CREAT|O_WRONLY|O_TRUNC
+#ifdef O_BINARY
+				|O_BINARY   /* necessary for Windows */
+#endif
+		
+			, 0666);
 	if (fd < 0)
 		return NULL;
 	return fdopen(fd, "wb");
