gh-120754: Fix memory leak in FileIO.__init__() (#124225)

vstinner · web-flow · commit 43cd7aa8cd88 · 2024-09-19T00:11:50.000+02:00
Free 'self-&gt;stat_atopen' before assigning it, since
io.FileIO.__init__() can be called multiple times manually
(especially by test_io).
diff --git a/Modules/_io/fileio.c b/Modules/_io/fileio.c
@@ -457,6 +457,7 @@ _io_FileIO___init___impl(fileio *self, PyObject *nameobj, const char *mode,
 #endif
     }
 
+    PyMem_Free(self->stat_atopen);
     self->stat_atopen = PyMem_New(struct _Py_stat_struct, 1);
     if (self->stat_atopen == NULL) {
         PyErr_NoMemory();

Original file line number	Diff line number	Diff line change
`@@ -457,6 +457,7 @@ _io_FileIO___init___impl(fileio self, PyObject nameobj, const char *mode,`
`457`	`457`	`#endif`
`458`	`458`	`}`
`459`	`459`
	`460`	`+ PyMem_Free(self->stat_atopen);`
`460`	`461`	`self->stat_atopen = PyMem_New(struct _Py_stat_struct, 1);`
`461`	`462`	`if (self->stat_atopen == NULL) {`
`462`	`463`	`PyErr_NoMemory();`