(Merge 3.3) Close #6822: ftplib.FTP.storlines() expects a binary file, not a text file

vstinner · vstinner · commit 4489e927a6e0 · 2013-04-02T22:13:49.000+02:00
Add an unit test to ensure that text files are rejectect (with TypeError)
diff --git a/Lib/test/test_ftplib.py b/Lib/test/test_ftplib.py
@@ -588,6 +588,10 @@ def test_storlines(self):
         self.client.storlines('stor foo', f, callback=lambda x: flag.append(None))
         self.assertTrue(flag)
 
+        f = io.StringIO(RETR_DATA.replace('\r\n', '\n'))
+        # storlines() expects a binary file, not a text file
+        self.assertRaises(TypeError, self.client.storlines, 'stor foo', f)
+
     def test_nlst(self):
         self.client.nlst()
         self.assertEqual(self.client.nlst(), NLST_DATA.split('\r\n')[:-1])
