Add a missing Py_DECREF to BaseException__unicode__ .

brettcannon · brettcannon · commit 46872b16135c · 2006-03-02T04:31:55.000Z
diff --git a/Python/exceptions.c b/Python/exceptions.c
@@ -285,16 +285,22 @@ BaseException__unicode__(PyObject *self, PyObject *args)
 	}
 	else if (args_len == 1) {
 		PyObject *temp = PySequence_GetItem(args, 0);
+		PyObject *unicode_obj;
+
 		if (!temp) {
 			Py_DECREF(args);
 			return NULL;
 		}
 		Py_DECREF(args);
-		return PyObject_Unicode(temp);
+		unicode_obj = PyObject_Unicode(temp);
+		Py_DECREF(temp);
+		return unicode_obj;
 	}
 	else {
+		PyObject *unicode_obj = PyObject_Unicode(args);
+
 		Py_DECREF(args);
-		return PyObject_Unicode(args);
+		return unicode_obj;
 	}
 }
 #endif /* Py_USING_UNICODE */

Original file line number	Diff line number	Diff line change
`@@ -285,16 +285,22 @@ BaseException__unicode__(PyObject self, PyObject args)`
`285`	`285`	`}`
`286`	`286`	`else if (args_len == 1) {`
`287`	`287`	`PyObject *temp = PySequence_GetItem(args, 0);`
	`288`	`+ PyObject *unicode_obj;`
	`289`	`+`
`288`	`290`	`if (!temp) {`
`289`	`291`	`Py_DECREF(args);`
`290`	`292`	`return NULL;`
`291`	`293`	`}`
`292`	`294`	`Py_DECREF(args);`
`293`		`- return PyObject_Unicode(temp);`
	`295`	`+ unicode_obj = PyObject_Unicode(temp);`
	`296`	`+ Py_DECREF(temp);`
	`297`	`+ return unicode_obj;`
`294`	`298`	`}`
`295`	`299`	`else {`
	`300`	`+ PyObject *unicode_obj = PyObject_Unicode(args);`
	`301`	`+`
`296`	`302`	`Py_DECREF(args);`
`297`		`- return PyObject_Unicode(args);`
	`303`	`+ return unicode_obj;`
`298`	`304`	`}`
`299`	`305`	`}`
`300`	`306`	`#endif /* Py_USING_UNICODE */`