The bufsize argument to Popen() should accept None meaning the default (0).

gvanrossum · gvanrossum · commit 46a05a7db5a6 · 2007-06-07T21:56:45.000Z
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
@@ -465,6 +465,8 @@ def __init__(self, args, bufsize=0, executable=None,
         _cleanup()
 
         self._child_created = False
+        if bufsize is None:
+            bufsize = 0  # Restore default
         if not isinstance(bufsize, int):
             raise TypeError("bufsize must be an integer")
 
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
@@ -455,6 +455,14 @@ def test_invalid_bufsize(self):
         else:
             self.fail("Expected TypeError")
 
+    def test_bufsize_is_none(self):
+        # bufsize=None should be the same as bufsize=0.
+        p = subprocess.Popen([sys.executable, "-c", "pass"], None)
+        self.assertEqual(p.wait(), 0)
+        # Again with keyword arg
+        p = subprocess.Popen([sys.executable, "-c", "pass"], bufsize=None)
+        self.assertEqual(p.wait(), 0)
+
     #
     # POSIX tests
     #

Original file line number	Diff line number	Diff line change
`@@ -455,6 +455,14 @@ def test_invalid_bufsize(self):`
`455`	`455`	`else:`
`456`	`456`	`self.fail("Expected TypeError")`
`457`	`457`
	`458`	`+ def test_bufsize_is_none(self):`
	`459`	`+ # bufsize=None should be the same as bufsize=0.`
	`460`	`+ p = subprocess.Popen([sys.executable, "-c", "pass"], None)`
	`461`	`+ self.assertEqual(p.wait(), 0)`
	`462`	`+ # Again with keyword arg`
	`463`	`+ p = subprocess.Popen([sys.executable, "-c", "pass"], bufsize=None)`
	`464`	`+ self.assertEqual(p.wait(), 0)`
	`465`	`+`
`458`	`466`	`#`
`459`	`467`	`# POSIX tests`
`460`	`468`	`#`