Closes Issue 21222.

kushaldas · kushaldas · commit 484f8a875b98 · 2014-04-16T01:05:50.000+05:30
Passing name keyword argument to mock.create_autospec now works.
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
@@ -2096,6 +2096,8 @@ def create_autospec(spec, spec_set=False, instance=False, _parent=None,
     elif is_type and instance and not _instance_callable(spec):
         Klass = NonCallableMagicMock
 
+    _name = _kwargs.pop('name', _name)
+
     _new_name = _name
     if _parent is None:
         # for a top level object no _new_name should be set
diff --git a/Lib/unittest/test/testmock/testmock.py b/Lib/unittest/test/testmock/testmock.py
@@ -1182,6 +1182,10 @@ def f(a, b):
                 func.mock_calls, [call(1, 2), call(3, 4)]
             )
 
+    #Issue21222
+    def test_create_autospec_with_name(self):
+        m = mock.create_autospec(object(), name='sweet_func')
+        self.assertIn('sweet_func', repr(m))
 
     def test_mock_add_spec(self):
         class _One(object):
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -37,6 +37,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #21222: Passing name keyword argument to mock.create_autospec now
+  works.
+
 - Issue #21197: Add lib64 -> lib symlink in venvs on 64-bit non-OS X POSIX.
 
 - Issue #17498: Some SMTP servers disconnect after certain errors, violating

Original file line number	Diff line number	Diff line change
`@@ -1182,6 +1182,10 @@ def f(a, b):`
`1182`	`1182`	`func.mock_calls, [call(1, 2), call(3, 4)]`
`1183`	`1183`	`)`
`1184`	`1184`
	`1185`	`+ #Issue21222`
	`1186`	`+ def test_create_autospec_with_name(self):`
	`1187`	`+ m = mock.create_autospec(object(), name='sweet_func')`
	`1188`	`+ self.assertIn('sweet_func', repr(m))`
`1185`	`1189`
`1186`	`1190`	`def test_mock_add_spec(self):`
`1187`	`1191`	`class _One(object):`