Fix bug 126587: matchobject.groupdict() leaks memory because of a missing

akuchling · akuchling · commit 48f224c877c7 · 2000-12-22T14:39:10.000Z
DECREF
diff --git a/Modules/_sre.c b/Modules/_sre.c
@@ -1996,6 +1996,7 @@ match_groupdict(MatchObject* self, PyObject* args, PyObject* kw)
         }
         /* FIXME: <fl> this can fail, right? */
         PyDict_SetItem(result, key, item);
+	Py_DECREF(item);
     }
 
     Py_DECREF(keys);

Original file line number	Diff line number	Diff line change
`@@ -1996,6 +1996,7 @@ match_groupdict(MatchObject* self, PyObject* args, PyObject* kw)`
`1996`	`1996`	`}`
`1997`	`1997`	`/* FIXME: <fl> this can fail, right? */`
`1998`	`1998`	`PyDict_SetItem(result, key, item);`
	`1999`	`+ Py_DECREF(item);`
`1999`	`2000`	`}`
`2000`	`2001`
`2001`	`2002`	`Py_DECREF(keys);`