bpo-36176: Fix IDLE autocomplete & calltip popup colors. (#12262)

terryjreedy · web-flow · commit 491ef53c1548 · 2019-03-10T20:18:40.000-04:00
Prevent conflicts with Linux dark themes
(and slightly darken calltip background).
diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
@@ -3,7 +3,11 @@ Released on 2019-10-20?
 ======================================
 
 
-bpl-36152: Remove colorizer.ColorDelegator.close_when_done and the
+bpo-36176: Fix IDLE autocomplete & calltip popup colors.
+Prevent conflicts with Linux dark themes
+(and slightly darken calltip background).
+
+bpo-36152: Remove colorizer.ColorDelegator.close_when_done and the
 corresponding argument of .close().  In IDLE, both have always been
 None or False since 2007.
 
diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py
@@ -189,7 +189,7 @@ def show_window(self, comp_lists, index, complete, mode, userWantsWin):
             pass
         self.scrollbar = scrollbar = Scrollbar(acw, orient=VERTICAL)
         self.listbox = listbox = Listbox(acw, yscrollcommand=scrollbar.set,
-                                         exportselection=False, bg="white")
+                                         exportselection=False)
         for item in self.completions:
             listbox.insert(END, item)
         self.origselforeground = listbox.cget("selectforeground")
diff --git a/Lib/idlelib/calltip_w.py b/Lib/idlelib/calltip_w.py
@@ -80,7 +80,8 @@ def showtip(self, text, parenleft, parenright):
     def showcontents(self):
         """Create the call-tip widget."""
         self.label = Label(self.tipwindow, text=self.text, justify=LEFT,
-                           background="#ffffe0", relief=SOLID, borderwidth=1,
+                           background="#ffffd0", foreground="black",
+                           relief=SOLID, borderwidth=1,
                            font=self.anchor_widget['font'])
         self.label.pack()
 
diff --git a/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst
@@ -0,0 +1,2 @@
+Fix IDLE autocomplete & calltip popup colors. Prevent conflicts with Linux
+dark themes (and slightly darken calltip background).

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Fix IDLE autocomplete & calltip popup colors. Prevent conflicts with Linux`
	`2`	`+dark themes (and slightly darken calltip background).`