Should check that PyObject_Str() really returned a string!

gvanrossum · gvanrossum · commit 4a0144c0de21 · 1998-06-09T15:08:41.000Z
diff --git a/Objects/stringobject.c b/Objects/stringobject.c
@@ -900,6 +900,11 @@ PyString_Format(format, args)
 				temp = PyObject_Str(v);
 				if (temp == NULL)
 					goto error;
+				if (!PyString_Check(temp)) {
+					PyErr_SetString(PyExc_TypeError,
+					  "%s argument has non-string str()");
+					goto error;
+				}
 				buf = PyString_AsString(temp);
 				len = PyString_Size(temp);
 				if (prec >= 0 && len > prec)
