Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 4a01fd2

Browse files
committed
Clean up Tcl/Tk building in the Windows buildbot scripts.
- Nix the 'noxp' option, it was for Win2k compatibility (which was dropped with Python 3.3) and made default ttk ugly on post-Win2k systems (#21665) - Use 'OPTS=symbols' instead of 'DEBUG=1'; symbols is the official method - Use core, shell, dlls, install-binaries, and install-libraries targets instead of all and install to avoid trying to 1) build packages that don't work with MSVC 10+ and 2) install unnecessary bits and pieces.
1 parent f9e49dd commit 4a01fd2

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

Tools/buildbot/external-amd64.bat

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ call "%VS100COMNTOOLS%\..\..\VC\vcvarsall.bat" x86_amd64
66

77
if not exist tcltk64\bin\tcl86tg.dll (
88
cd tcl-8.6.1.0\win
9-
nmake -f makefile.vc DEBUG=1 MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 clean all
10-
nmake -f makefile.vc DEBUG=1 MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 install
9+
nmake -f makefile.vc OPTS=symbols MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 clean core shell dlls
10+
nmake -f makefile.vc OPTS=symbols MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 install-binaries install-libraries
1111
cd ..\..
1212
)
1313

1414
if not exist tcltk64\bin\tk86tg.dll (
1515
cd tk-8.6.1.0\win
16-
nmake -f makefile.vc OPTS=noxp DEBUG=1 MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 TCLDIR=..\..\tcl-8.6.1.0 clean
17-
nmake -f makefile.vc OPTS=noxp DEBUG=1 MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 TCLDIR=..\..\tcl-8.6.1.0 all
18-
nmake -f makefile.vc OPTS=noxp DEBUG=1 MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 TCLDIR=..\..\tcl-8.6.1.0 install
16+
nmake -f makefile.vc OPTS=symbols MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 TCLDIR=..\..\tcl-8.6.1.0 clean
17+
nmake -f makefile.vc OPTS=symbols MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 TCLDIR=..\..\tcl-8.6.1.0 all
18+
nmake -f makefile.vc OPTS=symbols MACHINE=AMD64 INSTALLDIR=..\..\tcltk64 TCLDIR=..\..\tcl-8.6.1.0 install-binaries install-libraries
1919
cd ..\..
2020
)
2121

Tools/buildbot/external.bat

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ call "%VS100COMNTOOLS%\vsvars32.bat"
77
if not exist tcltk\bin\tcl86tg.dll (
88
@rem all and install need to be separate invocations, otherwise nmakehlp is not found on install
99
cd tcl-8.6.1.0\win
10-
nmake -f makefile.vc DEBUG=1 INSTALLDIR=..\..\tcltk clean all
11-
nmake -f makefile.vc DEBUG=1 INSTALLDIR=..\..\tcltk install
10+
nmake -f makefile.vc OPTS=symbols INSTALLDIR=..\..\tcltk clean core shell dlls
11+
nmake -f makefile.vc OPTS=symbols INSTALLDIR=..\..\tcltk install-binaries install-libraries
1212
cd ..\..
1313
)
1414

1515
if not exist tcltk\bin\tk86tg.dll (
1616
cd tk-8.6.1.0\win
17-
nmake -f makefile.vc OPTS=noxp DEBUG=1 INSTALLDIR=..\..\tcltk TCLDIR=..\..\tcl-8.6.1.0 clean
18-
nmake -f makefile.vc OPTS=noxp DEBUG=1 INSTALLDIR=..\..\tcltk TCLDIR=..\..\tcl-8.6.1.0 all
19-
nmake -f makefile.vc OPTS=noxp DEBUG=1 INSTALLDIR=..\..\tcltk TCLDIR=..\..\tcl-8.6.1.0 install
17+
nmake -f makefile.vc OPTS=symbols INSTALLDIR=..\..\tcltk TCLDIR=..\..\tcl-8.6.1.0 clean
18+
nmake -f makefile.vc OPTS=symbols INSTALLDIR=..\..\tcltk TCLDIR=..\..\tcl-8.6.1.0 all
19+
nmake -f makefile.vc OPTS=symbols INSTALLDIR=..\..\tcltk TCLDIR=..\..\tcl-8.6.1.0 install-binaries install-libraries
2020
cd ..\..
2121
)

0 commit comments

Comments
 (0)