Issue #23076: Path.glob() now raises a ValueError if it's called with an

berkerpeksag · berkerpeksag · commit 4a208e448e80 · 2016-01-30T17:50:48.000+02:00
invalid pattern.

Patch by Thomas Nyberg.
diff --git a/Lib/pathlib.py b/Lib/pathlib.py
@@ -1065,6 +1065,8 @@ def glob(self, pattern):
         """Iterate over this subtree and yield all existing files (of any
         kind, including directories) matching the given pattern.
         """
+        if not pattern:
+            raise ValueError("Unacceptable pattern: {!r}".format(pattern))
         pattern = self._flavour.casefold(pattern)
         drv, root, pattern_parts = self._flavour.parse_parts((pattern,))
         if drv or root:
diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py
@@ -1969,6 +1969,11 @@ def test_unsupported_flavour(self):
         else:
             self.assertRaises(NotImplementedError, pathlib.WindowsPath)
 
+    def test_glob_empty_pattern(self):
+        p = self.cls()
+        with self.assertRaisesRegex(ValueError, 'Unacceptable pattern'):
+            list(p.glob(''))
+
 
 @only_posix
 class PosixPathTest(_BasePathTest, unittest.TestCase):
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -1038,6 +1038,7 @@ Neal Norwitz
 Mikhail Novikov
 Michal Nowikowski
 Steffen Daode Nurpmeso
+Thomas Nyberg
 Nigel O'Brian
 John O'Connor
 Kevin O'Connor
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -73,6 +73,9 @@ Library
 - Issue #26202: copy.deepcopy() now correctly copies range() objects with
   non-atomic attributes.
 
+- Issue #23076: Path.glob() now raises a ValueError if it's called with an
+  invalid pattern.  Patch by Thomas Nyberg.
+
 - Issue #19883: Fixed possible integer overflows in zipimport.
 
 - Issue #26227: On Windows, getnameinfo(), gethostbyaddr() and
