In Lib/test/test_pty.py, wrap @expectedfailure to check if pty.STDIN_FILENO is a tty

8vasu · 8vasu · commit 4bb22ca70e8c · 2020-10-25T02:33:27.000-05:00
Signed-off-by: Soumendra Ganguly &lt;soumendraganguly@gmail.com&gt;
diff --git a/Lib/test/test_pty.py b/Lib/test/test_pty.py
@@ -69,6 +69,15 @@ def _readline(fd):
     reader = io.FileIO(fd, mode='rb', closefd=False)
     return reader.readline()
 
+def expectedFailureIfStdinIsTTY(fun):
+    # avoid isatty() for now
+    try:
+        tty.tcgetattr(pty.STDIN_FILENO)
+        return unittest.expectedFailure(fun)
+    except tty.error:
+        pass
+    return fun
+
 def expectedFailureOnBSD(fun):
     if platform.system().endswith("BSD"):
         return unittest.expectedFailure(fun)
@@ -103,7 +112,7 @@ def handle_sighup(signum, frame):
         # signal: just ignore the signal.
         pass
 
-    @unittest.expectedFailure
+    @expectedFailureIfStdinIsTTY
     def test_openpty(self):
         try:
             mode = tty.tcgetattr(pty.STDIN_FILENO)
