Issue #3740: Null-initialize module state.

loewis · loewis · commit 4e0630cb5276 · 2008-10-07T13:16:28.000Z
Reviewed by Benjamin Peterson.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -15,6 +15,8 @@ What's New in Python 3.0 beta 5
 Core and Builtins
 -----------------
 
+- Issue #3740: Null-initialize module state.
+
 - Issue #3946: PyObject_CheckReadBuffer crashed on a memoryview object.
 
 - Issue #1688: On Windows, the input() prompt was not correctly displayed if it
diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
@@ -113,6 +113,7 @@ PyModule_Create2(struct PyModuleDef* module, int module_api_version)
 			Py_DECREF(m);
 			return NULL;
 		}
+		memset(m->md_state, 0, module->m_size);
 	}
 			
 	d = PyModule_GetDict((PyObject*)m);

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ PyModule_Create2(struct PyModuleDef* module, int module_api_version)`
`113`	`113`	`Py_DECREF(m);`
`114`	`114`	`return NULL;`
`115`	`115`	`}`
	`116`	`+ memset(m->md_state, 0, module->m_size);`
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`d = PyModule_GetDict((PyObject*)m);`