bpo-39495: Remove default value from C impl of TreeBuilder.start (GH-18275)

hauntsaninja · web-flow · commit 4edc95cf0a29 · 2020-03-02T08:33:24.000+02:00
diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
@@ -2259,6 +2259,10 @@ def test_expat224_utf8_bug_file(self):
         text = text[6:-4]
         self.assertEqual(root.get('b'), text)
 
+    def test_39495_treebuilder_start(self):
+        self.assertRaises(TypeError, ET.TreeBuilder().start, "tag")
+        self.assertRaises(TypeError, ET.TreeBuilder().start, "tag", None)
+
 
 
 # --------------------------------------------------------------------
diff --git a/Misc/NEWS.d/next/Library/2020-01-30-07-02-02.bpo-39495.8LsIRN.rst b/Misc/NEWS.d/next/Library/2020-01-30-07-02-02.bpo-39495.8LsIRN.rst
@@ -0,0 +1 @@
+Remove default value from *attrs* parameter of :meth:`xml.etree.ElementTree.TreeBuilder.start` for consistency between Python and C implementations.
diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
@@ -3038,15 +3038,15 @@ _elementtree_TreeBuilder_close_impl(TreeBuilderObject *self)
 _elementtree.TreeBuilder.start
 
     tag: object
-    attrs: object = None
+    attrs: object(subclass_of='&PyDict_Type')
     /
 
 [clinic start generated code]*/
 
 static PyObject *
 _elementtree_TreeBuilder_start_impl(TreeBuilderObject *self, PyObject *tag,
                                     PyObject *attrs)
-/*[clinic end generated code: output=e7e9dc2861349411 input=95fc1758dd042c65]*/
+/*[clinic end generated code: output=e7e9dc2861349411 input=7288e9e38e63b2b6]*/
 {
     return treebuilder_handle_start(self, tag, attrs);
 }
diff --git a/Modules/clinic/_elementtree.c.h b/Modules/clinic/_elementtree.c.h

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Remove default value from attrs parameter of :meth:`xml.etree.ElementTree.TreeBuilder.start` for consistency between Python and C implementations.
Original file line number	Diff line number	Diff line change
`@@ -3038,15 +3038,15 @@ _elementtree_TreeBuilder_close_impl(TreeBuilderObject *self)`
`3038`	`3038`	`_elementtree.TreeBuilder.start`
`3039`	`3039`
`3040`	`3040`	`tag: object`
`3041`		`- attrs: object = None`
	`3041`	`+ attrs: object(subclass_of='&PyDict_Type')`
`3042`	`3042`	`/`
`3043`	`3043`
`3044`	`3044`	`[clinic start generated code]*/`
`3045`	`3045`
`3046`	`3046`	`static PyObject *`
`3047`	`3047`	`_elementtree_TreeBuilder_start_impl(TreeBuilderObject self, PyObject tag,`
`3048`	`3048`	`PyObject *attrs)`
`3049`		`-/[clinic end generated code: output=e7e9dc2861349411 input=95fc1758dd042c65]/`
	`3049`	`+/[clinic end generated code: output=e7e9dc2861349411 input=7288e9e38e63b2b6]/`
`3050`	`3050`	`{`
`3051`	`3051`	`return treebuilder_handle_start(self, tag, attrs);`
`3052`	`3052`	`}`