In release mode, PyUnicode_InternInPlace() does nothing if the input is NULL or

Victor Stinner · Victor Stinner · commit 4fae54cb0ee1 · 2011-10-03T02:01:52.000+02:00
not a unicode, instead of failing with a fatal error.

Use assertions in debug mode (provide better error messages).
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -12893,17 +12893,21 @@ PyUnicode_InternInPlace(PyObject **p)
 {
     register PyUnicodeObject *s = (PyUnicodeObject *)(*p);
     PyObject *t;
+#ifdef Py_DEBUG
+    assert(s != NULL);
+    assert(_PyUnicode_CHECK(s));
+#else
     if (s == NULL || !PyUnicode_Check(s))
-        Py_FatalError(
-            "PyUnicode_InternInPlace: unicode strings only please!");
+        return;
+#endif
     /* If it's a subclass, we don't really know what putting
        it in the interned dict might do. */
     if (!PyUnicode_CheckExact(s))
         return;
     if (PyUnicode_CHECK_INTERNED(s))
         return;
     if (PyUnicode_READY(s) == -1) {
-        assert(0 && "ready fail in intern...");
+        assert(0 && "PyUnicode_READY fail in PyUnicode_InternInPlace");
         return;
     }
     if (interned == NULL) {
