Issue #18599: Fix name attribute of _sha1.sha1() object. It now returns

tiran · tiran · commit 4fec4314cf24 · 2013-07-30T15:32:57.000+02:00
'SHA1' instead of 'SHA'.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -57,6 +57,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #18599: Fix name attribute of _sha1.sha1() object. It now returns
+  'SHA1' instead of 'SHA'.
+
 - Issue #18561: Skip name in ctypes' _build_callargs() if name is NULL.
 
 - Issue #18559: Fix NULL pointer dereference error in _pickle module
diff --git a/Modules/sha1module.c b/Modules/sha1module.c
@@ -415,7 +415,7 @@ SHA1_get_block_size(PyObject *self, void *closure)
 static PyObject *
 SHA1_get_name(PyObject *self, void *closure)
 {
-    return PyUnicode_FromStringAndSize("SHA1", 3);
+    return PyUnicode_FromStringAndSize("SHA1", 4);
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ SHA1_get_block_size(PyObject self, void closure)`
`415`	`415`	`static PyObject *`
`416`	`416`	`SHA1_get_name(PyObject self, void closure)`
`417`	`417`	`{`
`418`		`- return PyUnicode_FromStringAndSize("SHA1", 3);`
	`418`	`+ return PyUnicode_FromStringAndSize("SHA1", 4);`
`419`	`419`	`}`
`420`	`420`
`421`	`421`	`static PyObject *`