Fix a file descriptor leak in tests.

serhiy-storchaka · serhiy-storchaka · commit 57af913ce706 · 2023-12-14T20:02:55.000+02:00
diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py
@@ -2092,7 +2092,6 @@ def test_chown(self):
         dirname = self.mkdtemp()
         filename = tempfile.mktemp(dir=dirname)
         linkname = os.path.join(dirname, "chown_link")
-        dirfd = os.open(dirname, os.O_RDONLY)
         write_file(filename, 'testing chown function')
         os.symlink(filename, linkname)
 
@@ -2151,6 +2150,8 @@ def check_chown(path, uid=None, gid=None):
             shutil.chown(dirname, user, group)
             check_chown(dirname, uid, gid)
 
+        dirfd = os.open(dirname, os.O_RDONLY)
+        self.addCleanup(os.close, dirfd)
         basename = os.path.basename(filename)
         baselinkname = os.path.basename(linkname)
         shutil.chown(basename, uid, gid, dir_fd=dirfd)
