Only output the buffer size error label if it is used.

jackjansen · jackjansen · commit 5a1516bce5c9 · 2001-09-05T10:27:53.000Z
Shuts up another couple of gcc warnings.
diff --git a/Tools/bgen/bgen/bgenBuffer.py b/Tools/bgen/bgen/bgenBuffer.py
@@ -36,6 +36,7 @@ def __init__(self, size, datatype = 'char', sizetype = 'int', sizeformat = None)
 		self.datatype = datatype
 		self.sizetype = sizetype
 		self.sizeformat = sizeformat or type2format[sizetype]
+		self.label_needed = 0
 
 	def declare(self, name):
 		self.declareBuffer(name)
@@ -67,6 +68,7 @@ def getargsCheck(self, name):
 		Output('PyErr_SetString(PyExc_TypeError, "buffer length should be %s");',
 		       self.size)
 		Output("goto %s__error__;", name)
+		self.label_needed = 1
 		OutRbrace()
 		self.transferSize(name)
 	
@@ -83,9 +85,10 @@ def mkvalueArgs(self, name):
 		return "%s__out__, (int)%s" % (name, self.size)
 	
 	def cleanup(self, name):
-		DedentLevel()
-		Output(" %s__error__: ;", name)
-		IndentLevel()
+		if self.label_needed:
+			DedentLevel()
+			Output(" %s__error__: ;", name)
+			IndentLevel()
 
 
 class FixedCombinedInputOutputBufferType(FixedInputOutputBufferType):
diff --git a/Tools/bgen/bgen/bgenHeapBuffer.py b/Tools/bgen/bgen/bgenHeapBuffer.py
@@ -24,6 +24,7 @@ def getargsCheck(self, name):
 		OutLbrace()
 		Output('PyErr_NoMemory();')
 		Output("goto %s__error__;", name)
+		self.label_needed = 1
 		OutRbrace()
 		Output("%s__len__ = %s__in_len__;", name, name)
 
