* filemodule.c: added writelines() -- analogous to readlines()

gvanrossum · gvanrossum · commit 5a2a683e7299 · 1993-10-25T09:59:04.000Z
* import.c: fixed core dump when out-of-date .pyc file encountered (again!)
diff --git a/Objects/fileobject.c b/Objects/fileobject.c
@@ -541,6 +541,47 @@ file_write(f, args)
 	return None;
 }
 
+static object *
+file_writelines(f, args)
+	fileobject *f;
+	object *args;
+{
+	int i, n;
+	if (f->f_fp == NULL)
+		return err_closed();
+	if (args == NULL || !is_listobject(args)) {
+		err_setstr(TypeError,
+			   "writelines() requires list of strings");
+		return NULL;
+	}
+	n = getlistsize(args);
+	f->f_softspace = 0;
+	BGN_SAVE
+	errno = 0;
+	for (i = 0; i < n; i++) {
+		object *line = getlistitem(args, i);
+		int len;
+		int nwritten;
+		if (!is_stringobject(line)) {
+			RET_SAVE
+			err_setstr(TypeError,
+				   "writelines() requires list of strings");
+			return NULL;
+		}
+		len = getstringsize(line);
+		nwritten = fwrite(getstringvalue(line), 1, len, f->f_fp);
+		if (nwritten != len) {
+			RET_SAVE
+			err_errno(IOError);
+			clearerr(f->f_fp);
+			return NULL;
+		}
+	}
+	END_SAVE
+	INCREF(None);
+	return None;
+}
+
 static struct methodlist file_methods[] = {
 	{"close",	file_close},
 	{"flush",	file_flush},
@@ -552,6 +593,7 @@ static struct methodlist file_methods[] = {
 	{"seek",	file_seek},
 	{"tell",	file_tell},
 	{"write",	file_write},
+	{"writelines",	file_writelines},
 	{NULL,		NULL}		/* sentinel */
 };
 
diff --git a/Python/import.c b/Python/import.c
@@ -250,9 +250,10 @@ get_module(m, name, m_ret)
 				fprintf(stderr,
 				"# invalid precompiled file \"%s\"\n",
 					namebuf);
-				goto read_py;
 			}
 		}
+		if (co == NULL)
+			goto read_py;
 	}
 	else {
 read_py:

Original file line number	Diff line number	Diff line change
`@@ -250,9 +250,10 @@ get_module(m, name, m_ret)`
`250`	`250`	`fprintf(stderr,`
`251`	`251`	`"# invalid precompiled file \"%s\"\n",`
`252`	`252`	`namebuf);`
`253`		`- goto read_py;`
`254`	`253`	`}`
`255`	`254`	`}`
	`255`	`+ if (co == NULL)`
	`256`	`+ goto read_py;`
`256`	`257`	`}`
`257`	`258`	`else {`
`258`	`259`	`read_py:`