be extra careful with a borrowed reference when the GIL could be released (closes #8578)

benjaminp · benjaminp · commit 5c2b09e85655 · 2011-05-31T21:31:37.000-05:00
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -200,11 +200,13 @@ void pysqlite_do_all_statements(pysqlite_Connection* self, int action, int reset
         weakref = PyList_GetItem(self->statements, i);
         statement = PyWeakref_GetObject(weakref);
         if (statement != Py_None) {
+            Py_INCREF(statement);
             if (action == ACTION_RESET) {
                 (void)pysqlite_statement_reset((pysqlite_Statement*)statement);
             } else {
                 (void)pysqlite_statement_finalize((pysqlite_Statement*)statement);
             }
+            Py_DECREF(statement);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -200,11 +200,13 @@ void pysqlite_do_all_statements(pysqlite_Connection* self, int action, int reset`
`200`	`200`	`weakref = PyList_GetItem(self->statements, i);`
`201`	`201`	`statement = PyWeakref_GetObject(weakref);`
`202`	`202`	`if (statement != Py_None) {`
	`203`	`+ Py_INCREF(statement);`
`203`	`204`	`if (action == ACTION_RESET) {`
`204`	`205`	`(void)pysqlite_statement_reset((pysqlite_Statement*)statement);`
`205`	`206`	`} else {`
`206`	`207`	`(void)pysqlite_statement_finalize((pysqlite_Statement*)statement);`
`207`	`208`	`}`
	`209`	`+ Py_DECREF(statement);`
`208`	`210`	`}`
`209`	`211`	`}`
`210`	`212`