comples_from_string(): Move s_buffer[] up to the top-level function

warsaw · warsaw · commit 5ca1ef92384d · 2000-08-18T05:02:16.000Z
scope.  Previously, s_buffer[] was defined inside the
PyUnicode_Check() scope, but referred to in the outer scope via
assignment to s.  This quiets an Insure portability warning.
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -410,15 +410,14 @@ complex_from_string(PyObject *v)
 	int sw_error=0;
 	int sign;
 	char buffer[256]; /* For errors */
+	char s_buffer[256];
 	int len;
 
 	if (PyString_Check(v)) {
 		s = PyString_AS_STRING(v);
 		len = PyString_GET_SIZE(v);
 	}
 	else if (PyUnicode_Check(v)) {
-		char s_buffer[256];
-
 		if (PyUnicode_GET_SIZE(v) >= sizeof(s_buffer)) {
 			PyErr_SetString(PyExc_ValueError,
 				 "complex() literal too large to convert");
