Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 5df8c58

Browse files
brettcannonambv
authored andcommitted
Touch up the contributing notes (#3158)
* Mention how to find out what to do * Update URL * Thanks contributors * Explain there is no timeline
1 parent 41bbd82 commit 5df8c58

1 file changed

Lines changed: 28 additions & 12 deletions

File tree

.github/CONTRIBUTING.rst

Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,47 @@ Build Status
1212

1313
+ `Stable buildbots <http://buildbot.python.org/3.6.stable/>`_
1414

15-
- 3.5
16-
17-
+ `Stable buildbots <http://buildbot.python.org/3.5.stable/>`_
18-
1915
- 2.7
2016

2117
+ `Stable buildbots <http://buildbot.python.org/2.7.stable/>`_
2218

2319

20+
Thank You
21+
---------
22+
First off, thanks for contributing to the maintenance of the Python programming
23+
language and the CPython interpreter! Even if your contribution is not
24+
ultimately accepted, the fact you put time and effort into helping out is
25+
greatly appreciated.
26+
27+
2428
Contribution Guidelines
2529
-----------------------
26-
Please read the `devguide <https://cpython-devguide.readthedocs.io/>`_ for
30+
Please read the `devguide <https://devguide.python.org/>`_ for
2731
guidance on how to contribute to this project. The documentation covers
2832
everything from how to build the code to submitting a pull request. There are
2933
also suggestions on how you can most effectively help the project.
3034

3135
Please be aware that our workflow does deviate slightly from the typical GitHub
3236
project. Details on how to properly submit a pull request are covered in
33-
`Lifecycle of a Pull Request <https://cpython-devguide.readthedocs.io/pullrequest.html>`_.
34-
One key point is to keep comments on GitHub to only those related to the reviewing
35-
the code in the pull request. All other discussions -- e.g. about the issue being
36-
fixed -- should happen on bugs.python.org.
37-
38-
If you are making a code contribution or large documentation contribution,
39-
please feel free to add yourself to the ``Misc/ACKS`` file alphabetically.
37+
`Lifecycle of a Pull Request <https://devguide.python.org/pullrequest/>`_.
38+
We utilize various bots and status checks to help with this, so do follow the
39+
comments they leave and their "Details" links, respectively. The key points of
40+
our workflow that are not covered by a bot or status check are:
41+
42+
- All discussions that are not directly related to the code in the pull request
43+
should happen on bugs.python.org
44+
- Upon your first non-trivial pull request (which includes documentation changes),
45+
feel free to add yourself to ``Misc/ACKS``
46+
47+
48+
Setting Expectations
49+
--------------------
50+
Due to the fact that this project is entirely volunteer-run (i.e. no one is paid
51+
to work on Python full-time), we unfortunately can make no guarantees as to if
52+
or when a core developer will get around to reviewing your pull request.
53+
If no core developer has done a review or responded to changes made because of a
54+
"changes requested" review, please feel free to email python-dev to ask if
55+
someone could take a look at your pull request.
4056

4157

4258
Code of Conduct

0 commit comments

Comments
 (0)