Consider target when caching the JIT stencils

brandtbucher · brandtbucher · commit 5e229ed37071 · 2024-01-10T16:30:43.000-08:00
diff --git a/Tools/jit/build.py b/Tools/jit/build.py
@@ -275,10 +275,10 @@ def _process_relocations(self, stencil: Stencil, group: StencilGroup) -> None:
             stencil.holes.append(hole)
 
     def _handle_section(self, section: _S, group: StencilGroup) -> None:
-        raise NotImplementedError()
+        raise NotImplementedError(type(self))
 
     def _handle_relocation(self, base: int, relocation: _R, raw: bytes) -> Hole:
-        raise NotImplementedError()
+        raise NotImplementedError(type(self))
 
     async def _compile(
         self, opname: str, c: pathlib.Path, tempdir: pathlib.Path
@@ -306,10 +306,10 @@ async def _compile(
             # Don't make calls to weird stack-smashing canaries:
             "-fno-stack-protector",
             # We have three options for code model:
-            # - "small": the default, assumes that code and data reside in the lowest
-            #   2GB of memory (128MB on aarch64)
-            # - "medium": assumes that code resides in the lowest 2GB of memory, and
-            #   makes no assumptions about data (not available on aarch64)
+            # - "small": the default, assumes that code and data reside in the
+            #   lowest 2GB of memory (128MB on aarch64)
+            # - "medium": assumes that code resides in the lowest 2GB of memory,
+            #   and makes no assumptions about data (not available on aarch64)
             # - "large": makes no assumptions about either code or data
             "-mcmodel=large",
         ]
@@ -332,6 +332,7 @@ async def build_stencils(self) -> dict[str, StencilGroup]:
     def build(self, out: pathlib.Path) -> None:
         jit_stencils = out / "jit_stencils.h"
         hasher = hashlib.sha256()
+        hasher.update(self.sha256())
         hasher.update(PYTHON_EXECUTOR_CASES_C_H.read_bytes())
         hasher.update((out / "pyconfig.h").read_bytes())
         for dirpath, _, filenames in sorted(os.walk(TOOLS_JIT)):
