Fix reference leak in _pickle.

avassalotti · avassalotti · commit 637c7c475adc · 2013-04-20T21:28:21.000-07:00
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -5039,11 +5039,13 @@ do_append(UnpicklerObject *self, Py_ssize_t x)
             if (result == NULL) {
                 Pdata_clear(self->stack, i + 1);
                 Py_SIZE(self->stack) = x;
+                Py_DECREF(append_func);
                 return -1;
             }
             Py_DECREF(result);
         }
         Py_SIZE(self->stack) = x;
+        Py_DECREF(append_func);
     }
 
     return 0;

Original file line number	Diff line number	Diff line change
`@@ -5039,11 +5039,13 @@ do_append(UnpicklerObject *self, Py_ssize_t x)`
`5039`	`5039`	`if (result == NULL) {`
`5040`	`5040`	`Pdata_clear(self->stack, i + 1);`
`5041`	`5041`	`Py_SIZE(self->stack) = x;`
	`5042`	`+ Py_DECREF(append_func);`
`5042`	`5043`	`return -1;`
`5043`	`5044`	`}`
`5044`	`5045`	`Py_DECREF(result);`
`5045`	`5046`	`}`
`5046`	`5047`	`Py_SIZE(self->stack) = x;`
	`5048`	`+ Py_DECREF(append_func);`
`5047`	`5049`	`}`
`5048`	`5050`
`5049`	`5051`	`return 0;`