PyFloat_FromString(): Move s_buffer[] up to the top-level function

warsaw · warsaw · commit 67c1a04bbbad · 2000-08-18T05:00:03.000Z
scope.  Previously, s_buffer[] was defined inside the
PyUnicode_Check() scope, but referred to in the outer scope via
assignment to s.  This quiets an Insure portability warning.
diff --git a/Objects/floatobject.c b/Objects/floatobject.c
@@ -133,15 +133,14 @@ PyFloat_FromString(PyObject *v, char **pend)
 	const char *s, *last, *end;
 	double x;
 	char buffer[256]; /* For errors */
+	char s_buffer[256];
 	int len;
 
 	if (PyString_Check(v)) {
 		s = PyString_AS_STRING(v);
 		len = PyString_GET_SIZE(v);
 	}
 	else if (PyUnicode_Check(v)) {
-		char s_buffer[256];
-
 		if (PyUnicode_GET_SIZE(v) >= sizeof(s_buffer)) {
 			PyErr_SetString(PyExc_ValueError,
 				 "float() literal too large to convert");
