Explicit logic in set_autocommit

erlend-aasland · erlend-aasland · commit 6902738bf05a · 2022-08-16T00:09:26.000+02:00
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -2350,11 +2350,11 @@ set_autocommit(pysqlite_Connection *self, PyObject *val, void *Py_UNUSED(ctx))
     if (!autocommit_converter(val, &self->autocommit)) {
         return -1;
     }
-    if (self->autocommit == AUTOCOMMIT_ENABLED &&
-        !sqlite3_get_autocommit(self->db))
-    {
-        if (connection_txn_stmt(self, "COMMIT") < 0) {
-            return -1;
+    if (self->autocommit == AUTOCOMMIT_ENABLED) {
+        if (!sqlite3_get_autocommit(self->db)) {
+            if (connection_txn_stmt(self, "COMMIT") < 0) {
+                return -1;
+            }
         }
     }
     else if (self->autocommit == AUTOCOMMIT_DISABLED) {

Original file line number	Diff line number	Diff line change
`@@ -2350,11 +2350,11 @@ set_autocommit(pysqlite_Connection self, PyObject val, void *Py_UNUSED(ctx))`
`2350`	`2350`	`if (!autocommit_converter(val, &self->autocommit)) {`
`2351`	`2351`	`return -1;`
`2352`	`2352`	`}`
`2353`		`- if (self->autocommit == AUTOCOMMIT_ENABLED &&`
`2354`		`- !sqlite3_get_autocommit(self->db))`
`2355`		`- {`
`2356`		`- if (connection_txn_stmt(self, "COMMIT") < 0) {`
`2357`		`- return -1;`
	`2353`	`+ if (self->autocommit == AUTOCOMMIT_ENABLED) {`
	`2354`	`+ if (!sqlite3_get_autocommit(self->db)) {`
	`2355`	`+ if (connection_txn_stmt(self, "COMMIT") < 0) {`
	`2356`	`+ return -1;`
	`2357`	`+ }`
`2358`	`2358`	`}`
`2359`	`2359`	`}`
`2360`	`2360`	`else if (self->autocommit == AUTOCOMMIT_DISABLED) {`