PyUnicode_Contains(): The memcmp() call didn't take into account the

warsaw · warsaw · commit 6a043f3fe839 · 2002-08-06T19:03:17.000Z
width of Py_UNICODE.  Good catch, MAL.
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -3765,7 +3765,7 @@ int PyUnicode_Contains(PyObject *container,
     else {
 	end = lhs + (PyUnicode_GET_SIZE(u) - size);
 	while (lhs <= end) {
-	    if (memcmp(lhs++, rhs, size) == 0) {
+	    if (memcmp(lhs++, rhs, size * sizeof(Py_UNICODE)) == 0) {
 		result = 1;
 		break;
 	    }

Original file line number	Diff line number	Diff line change
`@@ -3765,7 +3765,7 @@ int PyUnicode_Contains(PyObject *container,`
`3765`	`3765`	`else {`
`3766`	`3766`	`end = lhs + (PyUnicode_GET_SIZE(u) - size);`
`3767`	`3767`	`while (lhs <= end) {`
`3768`		`- if (memcmp(lhs++, rhs, size) == 0) {`
	`3768`	`+ if (memcmp(lhs++, rhs, size * sizeof(Py_UNICODE)) == 0) {`
`3769`	`3769`	`result = 1;`
`3770`	`3770`	`break;`
`3771`	`3771`	`}`