handle case of negative shift

eendebakpt · eendebakpt · commit 70ad42a3c43f · 2025-01-29T12:19:51.000+01:00
diff --git a/Lib/test/test_opcache.py b/Lib/test/test_opcache.py
@@ -1425,6 +1425,7 @@ def binary_op_bitwise_extend():
         self.assert_specialized(binary_op_bitwise_extend, "BINARY_OP_EXTEND")
         self.assert_no_opcode(binary_op_bitwise_extend, "BINARY_OP")
 
+        # check that after specialization of >> we handle negative shifts
         for idx in range(100):
             a, b = 2, 1
             if idx == 99:
diff --git a/Python/specialize.c b/Python/specialize.c
@@ -2463,7 +2463,7 @@ compactlongs_guard(PyObject *lhs, PyObject *rhs)
 static int
 compactlong_compactnonnegativelong_guard(PyObject *lhs, PyObject *rhs)
 {
-    return (is_compactlong(lhs) && is_compactnonnegativelong(rhs);
+    return (is_compactlong(lhs) && is_compactnonnegativelong(rhs));
 }
 
 #define BITWISE_LONGS_ACTION(NAME, OP) \

Original file line number	Diff line number	Diff line change
`@@ -2463,7 +2463,7 @@ compactlongs_guard(PyObject lhs, PyObject rhs)`
`2463`	`2463`	`static int`
`2464`	`2464`	`compactlong_compactnonnegativelong_guard(PyObject lhs, PyObject rhs)`
`2465`	`2465`	`{`
`2466`		`- return (is_compactlong(lhs) && is_compactnonnegativelong(rhs);`
	`2466`	`+ return (is_compactlong(lhs) && is_compactnonnegativelong(rhs));`
`2467`	`2467`	`}`
`2468`	`2468`
`2469`	`2469`	`#define BITWISE_LONGS_ACTION(NAME, OP) \`