default_3way_compare(): When comparing the pointers, they must be cast

warsaw · warsaw · commit 71ff8d5dc5da · 2001-01-20T06:08:10.000Z
to integer types (i.e. Py_uintptr_t, our spelling of C9X's uintptr_t).
ANSI specifies that pointer compares other than == and != to
non-related structures are undefined.  This quiets an Insure
portability warning.
diff --git a/Objects/object.c b/Objects/object.c
@@ -525,8 +525,8 @@ default_3way_compare(PyObject *v, PyObject *w)
 
 	if (v->ob_type == w->ob_type) {
 		/* same type: compare pointers */
-		void *vv = v;
-		void *ww = w;
+		Py_uintptr_t vv = (Py_uintptr_t)v;
+		Py_uintptr_t ww = (Py_uintptr_t)w;
 		return (vv < ww) ? -1 : (vv > ww) ? 1 : 0;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -525,8 +525,8 @@ default_3way_compare(PyObject v, PyObject w)`
`525`	`525`
`526`	`526`	`if (v->ob_type == w->ob_type) {`
`527`	`527`	`/* same type: compare pointers */`
`528`		`- void *vv = v;`
`529`		`- void *ww = w;`
	`528`	`+ Py_uintptr_t vv = (Py_uintptr_t)v;`
	`529`	`+ Py_uintptr_t ww = (Py_uintptr_t)w;`
`530`	`530`	`return (vv < ww) ? -1 : (vv > ww) ? 1 : 0;`
`531`	`531`	`}`
`532`	`532`