Add missing PyObject_GC_Track and PyObject_GC_UnTrack calls to csv reader and

anmcn · anmcn · commit 77ead87f3086 · 2005-01-10T02:09:41.000Z
writer objects (other GC infrastructure already in place).
diff --git a/Modules/_csv.c b/Modules/_csv.c
@@ -776,6 +776,7 @@ Reader_iternext(ReaderObj *self)
 static void
 Reader_dealloc(ReaderObj *self)
 {
+	PyObject_GC_UnTrack(self);
         Py_XDECREF(self->dialect);
         Py_XDECREF(self->input_iter);
         Py_XDECREF(self->fields);
@@ -909,6 +910,7 @@ csv_reader(PyObject *module, PyObject *args, PyObject *keyword_args)
 		return NULL;
 	}
 
+	PyObject_GC_Track(self);
         return (PyObject *)self;
 }
 
@@ -1234,6 +1236,7 @@ static struct PyMemberDef Writer_memberlist[] = {
 static void
 Writer_dealloc(WriterObj *self)
 {
+	PyObject_GC_UnTrack(self);
         Py_XDECREF(self->dialect);
         Py_XDECREF(self->writeline);
 	if (self->rec != NULL)
@@ -1349,6 +1352,7 @@ csv_writer(PyObject *module, PyObject *args, PyObject *keyword_args)
                 Py_DECREF(self);
                 return NULL;
         }
+	PyObject_GC_Track(self);
         return (PyObject *)self;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -776,6 +776,7 @@ Reader_iternext(ReaderObj *self)`
`776`	`776`	`static void`
`777`	`777`	`Reader_dealloc(ReaderObj *self)`
`778`	`778`	`{`
	`779`	`+ PyObject_GC_UnTrack(self);`
`779`	`780`	`Py_XDECREF(self->dialect);`
`780`	`781`	`Py_XDECREF(self->input_iter);`
`781`	`782`	`Py_XDECREF(self->fields);`
`@@ -909,6 +910,7 @@ csv_reader(PyObject module, PyObject args, PyObject *keyword_args)`
`909`	`910`	`return NULL;`
`910`	`911`	`}`
`911`	`912`
	`913`	`+ PyObject_GC_Track(self);`
`912`	`914`	`return (PyObject *)self;`
`913`	`915`	`}`
`914`	`916`
`@@ -1234,6 +1236,7 @@ static struct PyMemberDef Writer_memberlist[] = {`
`1234`	`1236`	`static void`
`1235`	`1237`	`Writer_dealloc(WriterObj *self)`
`1236`	`1238`	`{`
	`1239`	`+ PyObject_GC_UnTrack(self);`
`1237`	`1240`	`Py_XDECREF(self->dialect);`
`1238`	`1241`	`Py_XDECREF(self->writeline);`
`1239`	`1242`	`if (self->rec != NULL)`
`@@ -1349,6 +1352,7 @@ csv_writer(PyObject module, PyObject args, PyObject *keyword_args)`
`1349`	`1352`	`Py_DECREF(self);`
`1350`	`1353`	`return NULL;`
`1351`	`1354`	`}`
	`1355`	`+ PyObject_GC_Track(self);`
`1352`	`1356`	`return (PyObject *)self;`
`1353`	`1357`	`}`
`1354`	`1358`