Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 79b52b7

Browse files
committed
Boosted the stack reservation for python.exe and python_w.exe from the
default 1MB to 2 million bytes. The test suite passes with -uall again (test_compiler no longer drives WinXP into an insane state).
1 parent e667e66 commit 79b52b7

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

Misc/NEWS

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,16 @@ Tests
7575
Windows
7676
-------
7777

78+
- Boosted the stack reservation for python.exe and pythonw.exe from
79+
the default 1MB to 2MB. Stack frames under VC 7.1 for 2.4 are enough
80+
bigger than under VC 6.0 for 2.3.4 that deeply recursive progams
81+
within the default sys.getrecursionlimit() default value of 1000 were
82+
able to suffer undetected C stack overflows. The standard test program
83+
test_compiler was one such program. If a Python process on Windows
84+
"just vanishes" without a trace, and without an error message of any
85+
kind, but with an exit code of 128, undetected stack overflow may be
86+
the problem.
87+
7888
Mac
7989
---
8090

PCbuild/python.vcproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
GenerateDebugInformation="TRUE"
4848
ProgramDatabaseFile=".\./python.pdb"
4949
SubSystem="1"
50+
StackReserveSize="2000000"
5051
BaseAddress="0x1d000000"
5152
TargetMachine="1"/>
5253
<Tool
@@ -109,6 +110,7 @@
109110
GenerateDebugInformation="TRUE"
110111
ProgramDatabaseFile=".\./python_d.pdb"
111112
SubSystem="1"
113+
StackReserveSize="2000000"
112114
BaseAddress="0x1d000000"
113115
TargetMachine="1"/>
114116
<Tool
@@ -179,6 +181,7 @@
179181
GenerateDebugInformation="TRUE"
180182
ProgramDatabaseFile=".\./python.pdb"
181183
SubSystem="1"
184+
StackReserveSize="2000000"
182185
BaseAddress="0x1d000000"
183186
TargetMachine="0"/>
184187
<Tool

PCbuild/pythonw.vcproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
GenerateDebugInformation="TRUE"
4343
ProgramDatabaseFile=".\./pythonw_d.pdb"
4444
SubSystem="2"
45+
StackReserveSize="2000000"
4546
BaseAddress="0x1d000000"
4647
TargetMachine="1"/>
4748
<Tool
@@ -108,6 +109,7 @@
108109
GenerateDebugInformation="TRUE"
109110
ProgramDatabaseFile=".\./pythonw.pdb"
110111
SubSystem="2"
112+
StackReserveSize="2000000"
111113
BaseAddress="0x1d000000"
112114
TargetMachine="1"/>
113115
<Tool
@@ -179,6 +181,7 @@
179181
GenerateDebugInformation="TRUE"
180182
ProgramDatabaseFile=".\./pythonw.pdb"
181183
SubSystem="2"
184+
StackReserveSize="2000000"
182185
BaseAddress="0x1d000000"
183186
TargetMachine="0"/>
184187
<Tool

0 commit comments

Comments
 (0)