bpo-29655: Fixed possible reference leaks in import *. (#301) (#348)

berkerpeksag · web-flow · commit 7accf2033d03 · 2017-02-27T20:41:21.000+03:00
Patch by Matthias Bussonnier. (cherry picked from commit 160edb4)
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -2857,13 +2857,16 @@ _PyEval_EvalFrameDefault(PyFrameObject *f, int throwflag)
         TARGET(IMPORT_STAR) {
             PyObject *from = POP(), *locals;
             int err;
-            if (PyFrame_FastToLocalsWithError(f) < 0)
+            if (PyFrame_FastToLocalsWithError(f) < 0) {
+                Py_DECREF(from);
                 goto error;
+            }
 
             locals = f->f_locals;
             if (locals == NULL) {
                 PyErr_SetString(PyExc_SystemError,
                     "no locals found during 'import *'");
+                Py_DECREF(from);
                 goto error;
             }
             err = import_all_from(locals, from);
