Better method name. Tighten inner-loop with bound methods.

rhettinger · rhettinger · commit 7babc1b6a5a5 · 2010-09-02T19:56:28.000Z
diff --git a/Lib/collections.py b/Lib/collections.py
@@ -173,7 +173,7 @@ def __eq__(self, other):
     def __del__(self):
         self.clear()                # eliminate cyclical references
 
-    def _move_to_end(self, key, PREV=0, NEXT=1):
+    def _renew(self, key, PREV=0, NEXT=1):
         'Fast version of self[key]=self.pop(key).   Private method for internal use.'
         link = self.__map[key]
         link_prev = link[PREV]
diff --git a/Lib/functools.py b/Lib/functools.py
@@ -128,6 +128,7 @@ def lru_cache(maxsize=100):
     def decorating_function(user_function, tuple=tuple, sorted=sorted,
                             len=len, KeyError=KeyError):
         cache = OrderedDict()           # ordered least recent to most recent
+        cache_popitem, cache_renew = cache.popitem, cache._renew
         kwd_mark = object()             # separate positional and keyword args
         lock = Lock()
 
@@ -139,15 +140,15 @@ def wrapper(*args, **kwds):
             try:
                 with lock:
                     result = cache[key]
-                    cache._move_to_end(key)     # record recent use of this key
+                    cache_renew(key)            # record recent use of this key
                     wrapper.hits += 1
             except KeyError:
                 result = user_function(*args, **kwds)
                 with lock:
                     cache[key] = result         # record recent use of this key
                     wrapper.misses += 1
                     if len(cache) > maxsize:
-                        cache.popitem(0)        # purge least recently used cache entry
+                        cache_popitem(0)        # purge least recently used cache entry
             return result
 
         def clear():
